Add swagger changes for zone redundancy property to databases, elastic pools and editions by emgu-ms · Pull Request #1813 · Azure/azure-rest-api-specs

emgu-ms · 2017-10-06T17:19:45Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

msftclas · 2017-10-06T17:45:20Z

All CLA requirements met.

fearthecowboy

@emgu-ms -- if you are an MS employee, make sure your account is tied to your domain account so that it's cleared by the CLA check.

if not, you can sign the cla (follow the instructions in the post...)

jaredmoo · 2017-10-07T15:36:52Z

Looks good. Just want to make sure this is on in at least 1 production region and has .NET SDK test written and working on your machine before this gets merged.

fearthecowboy · 2017-10-09T18:40:57Z

@emgu-ms -- ping this thread when you've satisfied @jaredmoo 's conditions.

jaredmoo · 2017-10-10T21:26:34Z

specification/sql/resource-manager/Microsoft.Sql/2014-04-01/capabilities.json

                  "description": "Whether or not zone redundancy is supported for the edition.",
-                  "type": "boolean",
+                  "type": "string",
+                  "format": "boolean"


I think you need a comma at the end here

jaredmoo

Looks good, please confirm that .NET SDK is working and then let's merge.

jaredmoo · 2017-10-10T21:42:04Z

Oh ho, linter errors. It looks like boolean format doesn't exist. I think you'll have to just remove those format's and treat it as plain string.

fearthecowboy · 2017-10-10T21:58:15Z

Is the value a boolean?

swagger uses "type":"boolean" -- not format

.

jaredmoo · 2017-10-10T22:00:43Z

The value is either "true" or "false" as a string, not true or false as a boolean literal. This is an unfortunate limitation in our API stack that implements api-version 2014-04-01. The later api-versions (which are being deployed soon) will have this as a real boolean.

fearthecowboy · 2017-10-10T22:01:14Z

Ah. ok.

,<

Ouch.

azuresdkciprbot · 2017-10-13T19:12:14Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2017-10-14T00:44:55Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

fearthecowboy · 2017-10-17T20:53:38Z

Hey @emgu-ms,

are we getting close to being ready to merge this?

emgu-ms · 2017-10-17T23:18:26Z

Yup! We're good! Thanks all :)

AutorestCI · 2017-10-18T17:08:28Z

Azure/azure-sdk-for-python#1546

AutorestCI · 2017-10-18T17:09:44Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-10-18T17:10:46Z

Azure/azure-sdk-for-ruby#1063

AutorestCI · 2017-10-18T18:54:11Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-10-20T22:46:17Z

Azure/azure-sdk-for-python#1555

AutorestCI · 2017-10-20T22:46:32Z

No modification for AutorestCI/azure-sdk-for-node

emgu-ms added 2 commits October 5, 2017 17:06

Add swagger changes for zone redundancy

b6cf83f

Fix indentation

b84f7a2

azuresdkci assigned fearthecowboy Oct 6, 2017

fearthecowboy approved these changes Oct 6, 2017

View reviewed changes

fearthecowboy added the Reviewed-FeedbackProvided label Oct 9, 2017

Change zone redundant property to be of type string

6f30150

jaredmoo reviewed Oct 10, 2017

View reviewed changes

Fix format error

621e22c

jaredmoo approved these changes Oct 10, 2017

View reviewed changes

Remove boolean format since it does not exist

ebc5abf

emgu-ms added 2 commits October 10, 2017 15:14

Change to enum

573a10a

Net SDK tests not working, try modifying swagger

ea3a64f

Change type back to boolean

2d9d9bb

fearthecowboy merged commit 213f67c into Azure:current Oct 18, 2017

AutorestCI mentioned this pull request Oct 18, 2017

[SQL] Add swagger changes for zone redundancy property to databases, elastic pools and editions Azure/azure-sdk-for-python#1546

Closed

AutorestCI mentioned this pull request Oct 18, 2017

Automatic PR from RestAPI-PR1813 Azure/azure-sdk-for-ruby#1063

Closed

emgu-ms mentioned this pull request Oct 18, 2017

Added Zone Redundant Property To Database, Elastic Pool and Edition Capability Azure/azure-sdk-for-net#3800

Merged

8 tasks

AutorestCI mentioned this pull request Oct 20, 2017

[SQL] Add swagger changes for zone redundancy property to databases, elastic pools and editions Azure/azure-sdk-for-python#1555

Closed

Conversation

emgu-ms commented Oct 6, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

msftclas commented Oct 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fearthecowboy left a comment

Choose a reason for hiding this comment

Uh oh!

jaredmoo commented Oct 7, 2017

Uh oh!

fearthecowboy commented Oct 9, 2017

Uh oh!

jaredmoo Oct 10, 2017

Choose a reason for hiding this comment

Uh oh!

jaredmoo left a comment

Choose a reason for hiding this comment

Uh oh!

jaredmoo commented Oct 10, 2017

Uh oh!

fearthecowboy commented Oct 10, 2017

Uh oh!

jaredmoo commented Oct 10, 2017

Uh oh!

fearthecowboy commented Oct 10, 2017

Uh oh!

azuresdkciprbot commented Oct 13, 2017

Uh oh!

azuresdkciprbot commented Oct 14, 2017

Uh oh!

fearthecowboy commented Oct 17, 2017

Uh oh!

emgu-ms commented Oct 17, 2017

Uh oh!

AutorestCI commented Oct 18, 2017

Uh oh!

AutorestCI commented Oct 18, 2017

Uh oh!

AutorestCI commented Oct 18, 2017

Uh oh!

AutorestCI commented Oct 18, 2017

Uh oh!

AutorestCI commented Oct 20, 2017

Uh oh!

AutorestCI commented Oct 20, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

emgu-ms commented Oct 6, 2017 •

edited by azuresdkci

Loading

msftclas commented Oct 6, 2017 •

edited

Loading